Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRAME] Introduce force_adjust_total_issuance #3001

Merged
merged 25 commits into from
Jan 30, 2024
Merged

[FRAME] Introduce force_adjust_total_issuance #3001

merged 25 commits into from
Jan 30, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jan 19, 2024 •
edited
Loading

Add Balances::force_adjust_total_issuance as preparation for fixing polkadot-fellows/runtimes#147.
Important changes in substrate/frame/balances/src/lib.rs.

TODO:

  • Update weights

@ggwpez
Add force_adjust_total_issuance
33986b4 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix weight files
e935f53 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix weight annotation
a455a8a 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add proper errors
d8ae79e 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add prdoc
997fc28 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Merge remote-tracking branch 'origin/master' into oty-adjust-ti
aa3d804
@ggwpez
Fix benchmark
cfb49fc 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Jan 19, 2024

bot bench substrate-pallet --pallet=pallet-balances
bot bench polkadot-pallet --pallet=pallet-balances --runtime=rococo

@ggwpez
Copy link
Member Author

ggwpez commented Jan 20, 2024

bot bench substrate-pallet --pallet=pallet_balances
bot bench polkadot-pallet --pallet=pallet_balances --runtime=rococo

command-bot added 3 commits January 20, 2024 10:09
@ggwpez
Copy link
Member Author

ggwpez commented Jan 20, 2024 •
edited
Loading

bot bench cumulus-collectives --pallet=pallet_balances
bot bench cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_balances
bot bench cumulus-bridge-hubs --runtime=bridge-hub-westend --pallet=pallet_balances
bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_balances
bot bench cumulus-assets --runtime=asset-hub-rococo --pallet=pallet_balances
bot bench cumulus-coretime --runtime=coretime-rococo --pallet=pallet_balances
bot bench cumulus-coretime --runtime=coretime-westend --pallet=pallet_balances
bot bench polkadot-pallet --runtime=westend --pallet=pallet_balances

@mordamax it could probably automatically detect where everywhere the is a pallet_balances*.rs weight file and then recommend a command, otherwise looking for them all manually is slightly annoying 😅

command-bot added 9 commits January 20, 2024 15:22
Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…
3c51c10 
…nto HEAD
".git/.scripts/commands/bench/bench.sh" --subcommand=runtime --runtim…
cf71bbe 
…e=westend --target_dir=polkadot --pallet=pallet_balances
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
d12e53d 
…=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_balances
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
b0f435c 
…=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_balances
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
fde5f46 
…=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_balances
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
af81253 
…=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_balances
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
5f290f7 
…=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_balances
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
af0c50b 
…=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_balances
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
c104593 
…=collectives-westend --runtime_dir=collectives --target_dir=cumulus --pallet=pallet_balances
@mordamax mordamax mentioned this pull request Jan 20, 2024
Closed
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Jan 22, 2024
@ggwpez
Beauty fixes
6489cd7 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review January 29, 2024 17:24
@ggwpez ggwpez requested a review from a team January 29, 2024 17:24
@ggwpez ggwpez requested a review from a team January 29, 2024 17:24
bkchr
bkchr reviewed Jan 29, 2024
View reviewed changes
prdoc/pr_3001.prdoc Outdated Show resolved Hide resolved
@ggwpez
Copy link
Member Author

ggwpez commented Jan 30, 2024

bot clean

@ggwpez
Fix upweights for testnets
086a590 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added this pull request to the merge queue Jan 30, 2024
Merged via the queue into master with commit 5a6f6d3 Jan 30, 2024
121 checks passed
@ggwpez ggwpez deleted the oty-adjust-ti branch January 30, 2024 23:19
bkontur added a commit to bkontur/runtimes that referenced this pull request Feb 18, 2024
@bkontur
[pallet_balances] adjust paritytech/polkadot-sdk#3001 (force_adjust_t…
f24c821 
…otal_issuance)
@ggwpez ggwpez mentioned this pull request Feb 23, 2024
Open
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@ggwpez @bkchr
[FRAME] Introduce force_adjust_total_issuance (paritytech#3001)
5eca009 
Add `Balances::force_adjust_total_issuance` as preparation for fixing
polkadot-fellows/runtimes#147.
Important changes in `substrate/frame/balances/src/lib.rs`.

TODO:
- [x] Update weights

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
@Aideepakchaudhary Aideepakchaudhary mentioned this pull request Oct 14, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggwpez @bkchr @liamaharon